Feature/mvp interview survey #4549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bycdiaz
reviewed
May 30, 2024
bycdiaz
reviewed
May 30, 2024
KevinMulhern
reviewed
Jun 3, 2024
JustWaveThings
force-pushed
the
feature/mvp_interview_survey
branch
from
72da55d
to
b612180
Compare
Because: * We want to be able to turn on and off the feature. This commit: * Adds a feature flag for the interview survey feature. * Adds a view, controller, and route for the feature. * Adds 2 tests for the feature flag.
JustWaveThings
force-pushed
the
feature/mvp_interview_survey
branch
from
b612180
to
a9dd576
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This PR
Issue
Related to #4524
Missing tests that were called for in that issue.There are now two system tests.Additional Information
The feature flag does work correctly in the view, but I'm not getting a redirect to work in the controller if the feature is disabled. It still renders the page as if the feature was enabled.This is resolved.