Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darkmode support #279

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Conversation

ungjinPark
Copy link
Contributor

Introduce my Dark Mode Support for Windows CCA

Hello, I'm an engineer who for testing accessibility of mobile applications and web pages. and I also have a low-visioning disability.

CCA is a good tools and I'm using it for my working always whenever testing for accessibility.

Background

Korean copy text wasn't translated, so I translated, and then suddenly I want to implements a dark mode for this tool. So I tried, and this is that result.

Note

I think maybe my codes are not good for team coding, and not good at other contributors to analyze, because I'm not familiar at 'electron' framework.

Dark mode Screenshots

Main

image

About CCA

image

Preferences

image

Deficiency

image

Would you review my result codes, build, test this?

@ungjinPark
Copy link
Contributor Author

ungjinPark commented Feb 7, 2023

Second commit is additional fixes for translation error of a <label> element for Application Theme on Preferences Window, there're no main changes.

To compare, Please open the first commit.

@ferllings
Copy link
Member

Thanks for the contribution.
I'll probably fix few minor contrast issues, but it looks good.

@ferllings
Copy link
Member

The navigation tabs font color on light mode should stay white

Light mode
Screenshot 2023-03-10 at 09 15 57

Original
Screenshot 2023-03-10 at 09 17 37

@ferllings
Copy link
Member

Thanks for your work.
If you also sync with the current main changes, I should be able to merge pretty quickly.

Note: next time, please try to break into smaller PRs, that's easier to review.

@ferllings
Copy link
Member

@ungjinPark Thanks. Could you check the question, about 'force-dark', and fix the tabs color?
So I can merge it.

@ungjinPark
Copy link
Contributor Author

@ferllings Oh, I'm sorry.
I got it, I going to modify that right now.

@ungjinPark
Copy link
Contributor Author

@ferllings I've pushed those fixes at the 'trnaslation' branch. And, in pull request #291, there was a critical markup error. But that error fix is also included in my additional commit.

@ferllings ferllings merged commit de2cb33 into ThePacielloGroup:main Mar 24, 2023
@ungjinPark ungjinPark deleted the darkmode-support branch June 1, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants