Allow compiling with the CUDA 11.4 compiler #1428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1190,7 +1190,7 @@ namespace sol { | |||
| } | |||
|
|
|||
| template <typename T> | |||
| decltype(auto) get_usertype(lua_State* L, int index = -lua_size_v<meta::unqualified_t<T>>) { | |||
| decltype(auto) get_usertype(lua_State* L, int index = -lua_size_v<meta::unqualified_t<T> >) { | |||
There was a problem hiding this comment.
Maybe these changes should require some clang-format suppressions, otherwise it might be wiped in the next instance ?
|
For the time being we've decided to go a different route that doesn't use sol2, so I'll close this to not take up developer time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request allows sol2 to be compiled by version 11.4 of the CUDA C++ compiler
nvcc. It essentially consists of workarounds for compiler bugs, and I certainly understand the annoyance of changing one's code due to bad compilers, but if this is merged then the mainline version of sol2 will be able to support our High Performance Computing codes with no modifications.Thank you for any time you spend reviewing this and considering it for merging, please let me know if there is anything I can do to help.
I don't think it should change any behavior, although the construction of a pointer by forwarded arguments change might be worth a look by someone with deeper C++ knowledge.