Actually fix the missing_locations bug this time. (#143)

Actually fix the bug this time.
ThePhar · Apr 10, 2023 · d7941c3 · d7941c3
1 parent a33a225
commit d7941c3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 13 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "archipelago.js",
-  "version": "0.5.1",
+  "version": "0.5.2",
   "description": "A general-purpose client library for communicating with Archipelago game servers, written for Node.js.",
   "license": "MIT",
   "main": "dist/index.js",

diff --git a/src/managers/LocationsManager.ts b/src/managers/LocationsManager.ts
@@ -93,21 +93,16 @@ export class LocationsManager {
         // Update our checked/missing arrays.
         if (packet.checked_locations) {
             for (const location of packet.checked_locations) {
-                if (!this._checked.includes(location)) this._checked.push(location);
+                if (!this._checked.includes(location)) {
+                    this._checked.push(location);
 
-                // Remove from missing locations array as well.
-                const index = this._missing.indexOf(location);
-                if (index !== -1) {
-                    this._missing = this._missing.splice(index, 1);
+                    // Remove from missing locations array as well.
+                    const index = this._missing.indexOf(location);
+                    if (index !== -1) {
+                        this._missing.splice(index, 1);
+                    }
                 }
             }
         }
-
-        // TODO: Does AP actually send missing locations?
-        if (packet.missing_locations) {
-            for (const location of packet.missing_locations) {
-                this._missing.filter((missing) => missing !== location);
-            }
-        }
     }
 }