Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct schemaLocation for urlset (v4 compat) #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

redjam13
Copy link
Contributor

Description

@ThePixelDeveloper re PR #69 - it seems this has been tagged in 4.5.6 but it looks like it should have been tagged as 5.1.4?

The change in this PR would be the change needed if we wanted to patch 4.*

I think this may be breaking for anyone on ^4 - is it possible to delete the 4.5.6 tag / make a new one with the changes in this PR?

@rogamoore
Copy link

rogamoore commented Jun 9, 2020

@ThePixelDeveloper Would it possible to tag a new version 5.1.4 as suggested by @redjam13 ?

@JoshBour
Copy link

I agree, as it is you have to use dev-master or 4.5.6 to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants