Handle cases where getPlayerSlot() returns undefined #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bancho.js joins an existing lobby, you can receive playerMoved or
playerLeft events before bancho.js had the time to fetch the lobby
info. When that happens, an unhandled error is thrown, since "undefined"
is not a valid key for the slots array.
I chose to just check if getPlayerSlot() returns something, but a better
fix might be to ignore those events until the lobby is initialized.
Original errors (as logged by sentry):