Reduce image size by adding flag depth 1 when git cloning #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShutdownRepo
approved these changes
Apr 15, 2024
ShutdownRepo
added
enhancement
|
It may be a deliberate "miss". I have to check if it works even if we add depth 1 |
|
Let’s see what the runners think 😄 |
|
Hey @gbe, Can you push a commit to sync the pipeline ? |
|
Done |
QU35T-code
approved these changes
Apr 15, 2024
|
Pipeline is ok ☑️ |
QU35T-code
added
ready for merge
ShutdownRepo
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some tools missed the flag
--depth 1forgit clone.For some tools, it was simply forgotten.
For others, the flag --depth 1 was removed for temp fixes reasons.
This PR reinstates the depth flag to clone directly the appropriate branch in a single command instead of doing a
git clonefollowed by agit checkout:Example with sliver:
git -C /opt/tools/ clone --branch v1.5.41 --depth 1 https://github.com/BishopFox/sliver.gitAnother with Bloodhound-CE:
git -C /opt/tools/ clone --branch bloodhound-ce --depth 1 https://github.com/dirkjanm/BloodHound.py BloodHound-CE.pyAbout sliver, I moved the temp fix criticalecho at the beginning of the function to only clone the repo if the date condition is met. I hope it's ok like this.