Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] GitHub Actions "release" workflow #10

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Conversation

MNThomson
Copy link
Collaborator

@MNThomson MNThomson commented Aug 25, 2023

Automatically publish release binaries on version bump

Closes: #6

This CI workflow will run on any push to master:

  • Build Step

    • Build binaries for Linux, Windows, & MacOS
    • Upload the binaries
  • Release step

    • Download all previous binaries
    • Publish release with binaries if top level Cargo.toml version changes

Future work

@ThePrimeagen You mentioned install scripts, so I'll leave that for you to figure out, something like this could work

wget $(curl -sL https://api.github.com/repos/ThePrimeagen/htmx-lsp/releases/latest | jq -r ".assets[].browser_download_url" | grep "htmx-lsp-linux-x64")

@MNThomson MNThomson self-assigned this Aug 25, 2023
@MNThomson
Copy link
Collaborator Author

MNThomson commented Aug 26, 2023

This is an exploratory PR, not sure if this is the direction you are thinking.
Additionally, I should probably remove this being triggered on every PR run (but the green checkmarks look pretty for now)

@ThePrimeagen
Copy link
Owner

this is incredible. let me review quickly

@ThePrimeagen
Copy link
Owner

remember @MNThomson you have merge privs :)

if you find my review slow, you can merge if you are confident

@ThePrimeagen
Copy link
Owner

i think this looks great (though i am pretty terrible at github ci. i live in jenkins)

@ThePrimeagen ThePrimeagen merged commit 6e6a201 into master Aug 28, 2023
6 checks passed
@MNThomson MNThomson deleted the max/ghactions-release branch August 29, 2023 03:03
@MNThomson
Copy link
Collaborator Author

Bleck, I'm so sorry for your loss (of having to use Jenkins)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Artifacts
3 participants