feat: use treesitter Query for building Positions #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing with the tree-sitter is quite fun :)
I figured tree-sitter comes with a built-in query feature, I'm not sure it is more performant than the current implementation, I didn't test it, but I'd place my bet on that.
I used this for reference:
https://tree-sitter.github.io/tree-sitter/using-parsers#pattern-matching-with-queries
Also their unit tests https://github.com/tree-sitter/tree-sitter/blob/master/cli/src/tests/query_test.rs
I didn't remove the dead code, I just kept it as a comparison, but accordingly with the tests, they are behaving the same. This implementation also contains the fix for #11
This implementation doesn't address the suggesting when editing an attribute in the middle of other hx-*
For instance: