Binary distribution: Use Github API to get OLD_VERSION
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenperera
changed the title
OLD_VERSIONOLD_VERSION
praveenperera
force-pushed
the
fix-release
branch
from
aaa80ee
to
69237a5
Compare
praveenperera
force-pushed
the
fix-release
branch
from
69237a5
to
eb0c51b
Compare
|
let me get #22 in first, then we will go to this one. sounds good? |
|
Sounds good, CI should be passing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the release mechanism a little less brittle, uses the Github API to get the last released version, instead of the last commit. Also added a condition for handling no releases, so merging his will release
0.1.0.Tested here: https://github.com/praveenperera/htmx-lsp/releases/tag/0.1.0
I usually release rust binaries a little differently, I use cross to release for more targets and upload the
tar.gz(linux, macOS) or.zip(windows) instead of the binary directly. Which makes for slightly smaller downloads.See: https://github.com/avencera/rustywind/releases/tag/v0.19.0
If you prefer that way I can just bring the GitHub action over that I used there.