Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure offset encoding on apply_text_edits #217

Open
teddylear opened this issue Jan 14, 2022 · 0 comments
Open

Configure offset encoding on apply_text_edits #217

teddylear opened this issue Jan 14, 2022 · 0 comments
Labels
improvement Not a bug but can be improved

Comments

@teddylear
Copy link
Collaborator

With the addition of adding the offset encoding to apply_text_edits, we set the default to utf-16 to make tests pass in the current state. However, we may want to set this via lsp as noted on this PR using vim.lsp.buf_get_clients(bufnr)[1].offset_encoding. Then we could default back to utf-16 if lsp not present (or set to some other default via configuration?). This would however mean that we would need an lsp in the CI, which would be interesting to add back in...

@teddylear teddylear changed the title How to configure offset encoding on apply_text_edits Configure offset encoding on apply_text_edits Jan 14, 2022
@pranavrao145 pranavrao145 added the improvement Not a bug but can be improved label Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Not a bug but can be improved
Projects
None yet
Development

No branches or pull requests

2 participants