Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document: add separator as a param #71

Merged
merged 2 commits into from
Mar 19, 2023
Merged

Document: add separator as a param #71

merged 2 commits into from
Mar 19, 2023

Conversation

naxels
Copy link
Contributor

@naxels naxels commented Mar 18, 2023

This resolves #70

For backward compatibility the default stays at "-"

Thank you for considering this.

@jrg94 jrg94 requested a review from a team March 19, 2023 01:44
@jrg94 jrg94 self-assigned this Mar 19, 2023
@jrg94 jrg94 added the enhancement New feature or request label Mar 19, 2023
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! You can see my comments in #70. I think I'm going to rework all of this at some point in the future, though the change will definitely not be backwards compatible. Things to think about in the 1.0 release.

@jrg94 jrg94 merged commit f3e3396 into TheRenegadeCoder:main Mar 19, 2023
@jrg94
Copy link
Member

jrg94 commented Mar 19, 2023

This won't get a release right away. If you want to expedite that process a bit, you'll have to go into the setup.py file and increment the version.

@jrg94 jrg94 mentioned this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to set custom _get_file_name separator
2 participants