Test fetch of profile for bad wiki user name

TheRestartProject · Aug 2, 2021 · e3d305f · e3d305f
1 parent eb06d17
commit e3d305f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/app/Http/Controllers/UserController.php b/app/Http/Controllers/UserController.php
@@ -1177,6 +1177,10 @@ public static function getThumbnail(Request $request)
     {
         $user = User::where('mediawiki', $request->input('wiki_username'))->first();
 
+        if (!$user) {
+            abort('404', 'Wiki user not found');
+        }
+
         if (isset($user->getProfile($user->id)->path) && ! is_null($user->getProfile($user->id)->path)) {
             $thumbnailPath = config('app.url').'/uploads/thumbnail_'.$user->getProfile($user->id)->path;
         } else {

diff --git a/tests/Feature/Users/ProfileTest.php b/tests/Feature/Users/ProfileTest.php
@@ -10,6 +10,7 @@
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Support\Facades\Event;
 use Illuminate\Validation\UnauthorizedException;
+use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Tests\TestCase;
 
 class ProfileTest extends TestCase
@@ -120,4 +121,9 @@ public function testEditBadPassword()
 
         $response->assertSee('The passwords are not identical!');
     }
+
+    public function testBadMediaWikiId() {
+        $this->expectException(NotFoundHttpException::class);
+        $this->get('/user/thumbnail?wiki_username=invalid');
+    }
 }