Fix bejob and added md5 and script fixes #82
Conversation
…parent and caused type error.
… needs new upload.
| /** | ||
| * @throws RuntimeException if a value is requested that does not exist. | ||
| * @param id Configuration value to return. | ||
| */ |
There was a problem hiding this comment.
As you already said, runtime exceptions are not the best way to go. Is there something like a ConfigurationException? If not, would it make sense to create this kind of exception?
There was a problem hiding this comment.
- Apparently, it is good practice to reuse official/existing core exceptions:
https://stackoverflow.com/questions/10016550/java-best-practices-when-throwing-exceptions-throwing-core-java-exceptions - There is https://docs.oracle.com/javase/7/docs/api/javax/xml/datatype/DatatypeConfigurationException.html, but the "Datatype..." does not fit. I would not use it here.
- Maybe https://docs.oracle.com/javase/7/docs/api/java/text/ParseException.html, but I would not use it, because the configuration tree is not only build by parsing.
That's what I could find. I would make a new ConfigurationException.
There was a problem hiding this comment.
Ok, that sounds reasonable. Leave it for now, but I'll create an issue for it.
| @@ -4,13 +4,13 @@ set -e | |||
| increasebuildonly=${increasebuildonly-false} | |||
|
|
|||
| # Check for configured plugin directories. Set empty if no dirs are configured. | |||
| pluginDirectories=`grep pluginDirectories ${customconfigfile}` | |||
| [[ -z "$pluginDirectories" ]] && pluginDirectories="pluginDirectories=" | |||
| pluginDirectories=`grepFromConfigFile pluginDirectories $customconfigfile` | |||
There was a problem hiding this comment.
Why did you remove the curlies?
There was a problem hiding this comment.
I changed the line and in the course of editing removed them, apparently. As they are meaningless in this context I could leave them away, but if you wish I add them again.
There was a problem hiding this comment.
Was only a question :D just leave it.
You were right. I forgot this pull request.