Skip to content

Commit

Permalink
Merge pull request #35 from TheRoddyWMS/library-version-bumps-and-gro…
Browse files Browse the repository at this point in the history
…ovification

Bumped libraries and fixed a test
  • Loading branch information
vinjana committed Jan 25, 2024
2 parents 0c03c97 + 97620d5 commit 2785d68
Show file tree
Hide file tree
Showing 9 changed files with 138 additions and 109 deletions.
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,7 @@ gradle-app.setting
### IntelliJ
.idea
/out/

.classpath
.project
.settings
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ where you substitute the correct proxies and ports required for your environment

## Changelog

* 2.4.1

- Patch: Library update
- Patch: Changed one logging message
- Patch: Fixed a unit test
- Patch: Code layout refactorings and groovification

* 2.4.0

- Minor: Improved reporting of stdout and stderr for executed commands
Expand Down
6 changes: 3 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ repositories {
}

dependencies {
compile 'org.codehaus.groovy:groovy-all:2.4.9'
testCompile 'junit:junit:4.12'
compile 'org.codehaus.groovy:groovy-all:2.4.21'
testCompile 'junit:junit:4.13.1'
testCompile 'org.spockframework:spock-core:1.1-groovy-2.4'
compile group: 'commons-codec', name: 'commons-codec', version: '1.9'
compile group: 'commons-codec', name: 'commons-codec', version: '1.13'
compile group: 'org.apache.commons', name: 'commons-io', version: '1.3.2'
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ class LocalExecutionHelper {
OutputStream outputStream = null,
ExecutorService executorService = executorService) {
List<String> bashCommand = ["bash", "-c", command]
logger.postRareInfo("Executing the command ${bashCommand} locally.")
logger.postRareInfo("Executing command locally: ${bashCommand}")
ProcessBuilder processBuilder = new ProcessBuilder(bashCommand)
Process process = processBuilder.start()
CompletableFuture<List<String>> stdoutF
Expand Down
2 changes: 1 addition & 1 deletion src/main/groovy/de/dkfz/roddy/tools/BufferValue.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ package de.dkfz.roddy.tools
* However floating point values can be parsed and will be rounded to their Integers.
* Created by heinold on 10.11.15.
*/
public class BufferValue {
class BufferValue {

/**
* The stored value aligned to KiloByte
Expand Down
Loading

0 comments on commit 2785d68

Please sign in to comment.