Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment closing tag chopped off #1

Open
TheSandDoctor opened this issue Jul 25, 2023 · 0 comments
Open

Comment closing tag chopped off #1

TheSandDoctor opened this issue Jul 25, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@TheSandDoctor
Copy link
Owner

TheSandDoctor commented Jul 25, 2023

Bot chopped off an HTML comment closing character. Based on a review of its last two runs, this appears to have been the first time that it came across an entry needing moving with a comment.

This does not appear to be an issue with the Python 2 to 3 conversion and it even performed a similar move perfectly that contained a second comment. I haven't been able to test this hypothesis further, but I believe that it might have something to do with the last +1 in the index selection at line 233. "RSconfig.insert + 1:" (since it is a comment to skip essentially a character); one would just think that the issue would be in every line if this was the issue. I investigated the string that worked and the one that failed in case there was a difference or something special about the string that failed, but they do appear identical, so this is a rather confusing bug.

https://github.com/TheSandDoctor/Edit-restriction-clerking/blob/6e2e9ad7b1947206e27afc41a284c2a93664e7b5/restrict.py#L233C3-L233C60

This is an issue that will need to be watched for closely in future runs.

@TheSandDoctor TheSandDoctor added the bug Something isn't working label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant