Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wonder and colony #140

Merged
merged 5 commits into from May 9, 2024
Merged

wonder and colony #140

merged 5 commits into from May 9, 2024

Conversation

TheShadowOfHassen
Copy link
Owner

No description provided.

Co-authored-by: indoptogopt <135018641+indoptogopt@users.noreply.github.com>
@TheShadowOfHassen
Copy link
Owner Author

Is this OK to merge?

@indoptogopt
Copy link
Contributor

To be honest, the colony text lacks some depth (and length). I'd recommend to check out the articles I linked to in the forum thread.

@TheShadowOfHassen
Copy link
Owner Author

I added a bit more information, but those articles basically say what I did, just longer.

@indoptogopt
Copy link
Contributor

More or less, yes. But you could talk a bit more about the military value of these colonies. Maybe: When and how were they called up? How many and how important were the settlers for the army?

@TheShadowOfHassen
Copy link
Owner Author

I have not been able to find that information, honestly I know they were historically called military colonies but all the information I've seen haven't really explained why. I added a bit more detail on what the Greeks did, but I think it'll have to be good the way it is,

Copy link
Contributor

@indoptogopt indoptogopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change up one of the two "serving as"s.

@indoptogopt
Copy link
Contributor

Ptolemaic and Seleucid military colonies were essentially the same. But it's ok. You can merge it now. There's really not a lot to say about this topic.

@TheShadowOfHassen
Copy link
Owner Author

Replaced one of the serving as. Thanks for the feedback, stuff like that is useful to keep in mind

@TheShadowOfHassen TheShadowOfHassen merged commit 9e75532 into main May 9, 2024
@TheShadowOfHassen TheShadowOfHassen deleted the selecluid-wonder-and-colony branch May 9, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants