New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wonder and colony #140
wonder and colony #140
Conversation
0-ad-history-mod-package/simulation/templates/structures/sele/military_colony.xml
Outdated
Show resolved
Hide resolved
0-ad-history-mod-package/simulation/templates/structures/sele/wonder.xml
Outdated
Show resolved
Hide resolved
0-ad-history-mod-package/simulation/templates/structures/sele/wonder.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: indoptogopt <135018641+indoptogopt@users.noreply.github.com>
Is this OK to merge? |
To be honest, the colony text lacks some depth (and length). I'd recommend to check out the articles I linked to in the forum thread. |
0-ad-history-mod-package/simulation/templates/structures/sele/military_colony.xml
Outdated
Show resolved
Hide resolved
…military_colony.xml
I added a bit more information, but those articles basically say what I did, just longer. |
More or less, yes. But you could talk a bit more about the military value of these colonies. Maybe: When and how were they called up? How many and how important were the settlers for the army? |
0-ad-history-mod-package/simulation/templates/structures/sele/military_colony.xml
Outdated
Show resolved
Hide resolved
…military_colony.xml
I have not been able to find that information, honestly I know they were historically called military colonies but all the information I've seen haven't really explained why. I added a bit more detail on what the Greeks did, but I think it'll have to be good the way it is, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd change up one of the two "serving as"s.
Ptolemaic and Seleucid military colonies were essentially the same. But it's ok. You can merge it now. There's really not a lot to say about this topic. |
0-ad-history-mod-package/simulation/templates/structures/sele/military_colony.xml
Outdated
Show resolved
Hide resolved
…military_colony.xml
Replaced one of the serving as. Thanks for the feedback, stuff like that is useful to keep in mind |
No description provided.