Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inf China Minigunner in Helix has extended firing range when attacking air unit together with a grounded Minigunner #300

Open
xezon opened this issue Sep 11, 2021 · 13 comments · May be fixed by #1091
Labels
Bug Something is not working right Controversial Is controversial Major Severity: Minor < Major < Critical < Blocker

Comments

@xezon
Copy link
Collaborator

xezon commented Sep 11, 2021

Inf China Minigunner in Helix has extended firing range when attacking air unit together with a grounded Minigunner. Reported by MTKing.

There's a similar situation that happens with inf helix, if garrisoned by a mini gunner and have the helix selected with another minigunner on the ground and shoot an air unit, the minigunner inside the lix will shoot the air unit with the same extended AA range

@xezon xezon added the Bug Something is not working right label Sep 11, 2021
@commy2
Copy link
Collaborator

commy2 commented Sep 11, 2021

I don't really understand how this is a bug. The extended range is meant against air units. It's only a bug when used against ground units.

This is independent of whether the Minigunner is inside a Helix or not. I can also use the extended range against air without grouping the Assault Helix with Minigunner passenger with another Minigunner on ground.

@xezon
Copy link
Collaborator Author

xezon commented Sep 11, 2021

I suspect what happens is, the Minigunner in the Helix will be able to acquire air target from further away with the assistance of the ground unit. Usually Minigunners in Helix will acquire target on rather short distance only.

@Stubbjax
Copy link
Collaborator

Minigunners inside a Helix will automatically acquire targets at a range much shorter than their actual attack range. Since it is not possible to target air units with a Helix, the Helix has to fly close to an air target before the Minigunners will begin firing. Selecting another unit that can target air in combination with the Helix allows players to attack air units without having to fly close to them first.

@MTKing4
Copy link
Collaborator

MTKing4 commented Sep 11, 2021

Yes, they get more range with this trick, without it they shoot the same way they shoot ground units meaning much shorter

@commy2
Copy link
Collaborator

commy2 commented Sep 11, 2021

@MTKing4
Copy link
Collaborator

MTKing4 commented Sep 11, 2021

Should test the new changes then

@commy2
Copy link
Collaborator

commy2 commented Sep 11, 2021

Sure! It's not in yet though. And it's also tagged as MAYBE.

@MTKing4
Copy link
Collaborator

MTKing4 commented Sep 11, 2021

I will test the vanilla one then and show you how unfair it is

@MTKing4
Copy link
Collaborator

MTKing4 commented Sep 13, 2021

here it is

MiniHelix_1.mp4

@xezon
Copy link
Collaborator Author

xezon commented Sep 14, 2021

@commy2

Probably covered by my task here then:
https://github.com/xezon/GeneralsGamePatch/blob/main/Patch104pZH/Design/Tasks/commy2_tasks.txt#L27

Firing range is quite extreme. Maybe we can decrease it for Minigunner when it sits in Helix.

@alanblack166

It may require a bunch of weapon refactors. If you activate WeaponBonusPassedToPassengers and give the object a WeaponBonusUpgrade module that is activated by default it will give them the PLAYER_UPGRADE weapon bonus flag. If the weapon has no existing PLAYER_UPGRADE bonuses, then you can use that to slightly modify the weapon via range, damage, rate of fire. But a complete weapon swap is impossible. Assuming China Infantry general has no infantry that use WeaponBonusUpgrade for upgrades, then weapon range adjustment in Helix is possible.

@Jundiyy
Copy link
Collaborator

Jundiyy commented Sep 14, 2021

Firing range is quite extreme. Maybe we can decrease it for Minigunner when it sits in Helix.

Mini Gunner already has an extreme air range, placing it inside a vehicle makes it even better as you can move around and still have the range.

Regarding inside a Helix, it's a normal AA range with bonus, it's not bugged out or anything. (I'm referring to the Mini Gunner inside the Helix alone, not the bug), it would still get this range without the bug, if it moves within range of an air unit then moves away, you gets this extreme range as the AA weapon is being used.

The bug itself, if this is the only fix for it then we prob don't have much other choices. Would result in changes to how a Helix is now micro'd vs air units, although it's not a bad change, just depends how players see it.

Edit: Just watched the change on the other page and Mini Gunner can shoot with AA weapon without coming in range first, so probs not the best solution.

@commy2
Copy link
Collaborator

commy2 commented Sep 14, 2021

@xezon If I understand this correctly, it would grant RPG-Soldiers (GLA) their AP Rockets when inside the Helix.

@Cryoblooded
Copy link

Cryoblooded commented Sep 15, 2021

i think you don't know understand why they have this insane range it' becaus of the bunker upgrade gives extra range for evey inf unit inside the helix i think it should stay as it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right Controversial Is controversial Major Severity: Minor < Major < Critical < Blocker
Projects
None yet
6 participants