Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

China Outpost and GLA Battlebus passengers engage targets on close distances only #858

Open
xezon opened this issue Aug 9, 2022 · 13 comments
Assignees
Labels
Controversial Is controversial Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker

Comments

@xezon
Copy link
Collaborator

xezon commented Aug 9, 2022

China Outpost and GLA Battlebus passengers engage targets on close distances only.

Weapon ListeningOutpostUpgradedDummyWeapon (also used by AirF_AmericaVehicleChinook)
  AttackRange = 90.0

Weapon BattleBusPassengerDummyWeapon
  AttackRange = 90.0

Weapon Infa_ChinaVehicleTroopCrawlerDummyWeapon
  AttackRange = 60.0

Weapon HumveeMissileWeaponAirDummy
  AttackRange = 150.0


Weapon ChinaInfantryTankHunterMissileLauncher
  AttackRange = 175.0

Weapon MissileDefenderMissileWeapon
  AttackRange = 175.0

Weapon TunnelDefenderRocketWeapon
  AttackRange = 175.0
@xezon xezon added Design Is a matter of game design Controversial Is controversial Minor Severity: Minor < Major < Critical < Blocker labels Aug 9, 2022
@commy2
Copy link
Collaborator

commy2 commented Aug 9, 2022

These should take into account Rebel/Ranger/Red Guard range which is 100. Dummy weapon range must be somewhat closer for it to work reliably, so 90 is fine vs ground on these units.

However, when engaging air targets, this range could be increased to ~150 or so. It would make targeting air units less wonky.

I have no idea what EALA was thinking with the Assault Troop Crawler though.

@xezon
Copy link
Collaborator Author

xezon commented Aug 9, 2022

So what would be the consequence of ListeningOutpostUpgradedDummyWeapon Range 120 with Red Guards on board? It does seem to work normally on Humvees, no?

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 9, 2022

Definitely don't touch, balanced as is.

@commy2
Copy link
Collaborator

commy2 commented Aug 9, 2022

So what would be the consequence of ListeningOutpostUpgradedDummyWeapon Range 120 with Red Guards on board?

Lets say you attacked a building like a War Factory. You select Outpost with Red Guards inside and click on the building. Outpost moves up to 120 feet close to target and just stands there. Then you click again, but nothing happens, because LO has reached the target and ordered the Red Guard to engage, but they can't.

@commy2
Copy link
Collaborator

commy2 commented Aug 9, 2022

It does seem to work normally on Humvees, no?

Not really. Vee with Ranger inside would move close enough to engage with the cannon, but for the Rangers to actually be able to fire, you would have to move order the Humvee close enough first and then give another attack order.

@xezon
Copy link
Collaborator Author

xezon commented Aug 9, 2022

Ok understood. But this dummy attack range does not take away from the maximum shooting range of the passenger right? It just determines how close the vehicle will approach the target. Is it desirable that Humvees and Outposts and Battlebuses and Crawlers have such vastly different attack ranges?

@xezon
Copy link
Collaborator Author

xezon commented Aug 9, 2022

What we definitely should do is make an explicit dummy weapon for the Airforce Chinook. Looks lazy to see the ListeningOutpostUpgradedDummyWeapon used for this.

@commy2
Copy link
Collaborator

commy2 commented Aug 9, 2022

But this dummy attack range does not take away from the maximum shooting range of the passenger right?

No, it only changes how far from target the transport unit will stop after an attack order. And if the target is inside range, it may prevent the unit from starting to move needlessly. It basically makes the units more responsive to player input and behave less erratically.

@commy2
Copy link
Collaborator

commy2 commented Aug 10, 2022

Definitely don't touch, balanced as is.

You need to elaborate on how units starting to move after passenger in range attack orders has anything to do with balance.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 10, 2022

Definitely don't touch, balanced as is.

You need to elaborate on how units starting to move after passenger in range attack orders has anything to do with balance.

Thought the issue was about 'slow reaction' times from Outposts & Battlebusses against incoming units, if you don't manually target to shoot from maximum range?

@commy2
Copy link
Collaborator

commy2 commented Aug 10, 2022

Do you have any steps to reproduce that? I would like to see if a change like this makes any difference.

@commy2 commy2 self-assigned this Aug 15, 2022
@xezon
Copy link
Collaborator Author

xezon commented Aug 18, 2022

Looks safe to me to match Infa_ChinaVehicleTroopCrawlerDummyWeapon ground range with ListeningOutpostUpgradedDummyWeapon to 90. Makes behaviour consistent and more predictable, especially when both units are in one attack group together.

@commy2
Copy link
Collaborator

commy2 commented Aug 13, 2023

Thought the issue was about 'slow reaction' times from Outposts & Battlebusses against incoming units

Both Outpost and Assault Troop Crawler have AutoAcquireEnemiesWhenIdle = No, so dummy weapon range does not affect idle AI at all. Passengers will engage if enemy is in range, regardless of what the transport does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Controversial Is controversial Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

No branches or pull requests

3 participants