Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Pilots Can Promote Combat Bikes #1164

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Fix: Pilots Can Promote Combat Bikes #1164

merged 1 commit into from
Oct 30, 2022

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 8, 2022

This prevents Piltos from promoting Combat Bikes. Because that makes no sense, and it leads to promoted units that should never promote, like Workers or Saboteurs. These units don't work correctly with promotions, meaning they don't receive any benefits from promotion (not even health or regen), so nothing is lost here.

@commy2 commy2 added Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker NProject Issue has been addressed in NProject Mod labels Sep 8, 2022
@Jundiyy
Copy link
Collaborator

Jundiyy commented Sep 8, 2022

or Saboteurs. These units don't work correctly with promotions, meaning they don't receive any benefits from promotion (not even health or regen), so nothing is lost here.

This is not correct.
Firstly, the Stealth Sabo can vet up, it has to go over crates, it doesn't get a better weapon, but it will have more health and auto heal.

Secondly, all units that vet up even though they usually can't, still gain more health. You can check vehicles or infantry.

And lastly, a vet 3 GLA Sabo will auto repair on a Bike (this is because the Bike is repairing, not the Sabo), but once off the bike, he will not heal but still have more health than a regular Sabo.

@commy2
Copy link
Collaborator Author

commy2 commented Sep 8, 2022

I looked it up and only Stealthgen Saboteur is trainable. vGLA Saboteur is not trainable.
(Demogen Saboteur is also trainable, WB only)

Good point about repairing Bike though.
Still doesn't make sense to put Pilots on Bikes.

@Jundiyy
Copy link
Collaborator

Jundiyy commented Sep 8, 2022

I looked it up and only Stealthgen Saboteur is trainable. vGLA Saboteur is not trainable. (Demogen Saboteur is also trainable, WB only)

Yes, that's why I mentioned Stealth :) 'Stealth Sabo'

Good point about repairing Bike though. Still doesn't make sense to put Pilots on Bikes.

Yup, it does feel odd as the Pilot just becomes the unit, but it's not been a problem.

@xezon
Copy link
Collaborator

xezon commented Sep 13, 2022

I do not mind either way, though if Pilot can be put into any other vehicle, then it is also ok to put it in Bike. Generally this is not seen as a problem in matches.

How would you like to proceed with this? Also, can we remove Bug label? To me it seems Design question, not Bug per se.

@commy2
Copy link
Collaborator Author

commy2 commented Sep 13, 2022

It's obviously a bug, because it can be used to promote Workers and other untrainable units.

@xezon
Copy link
Collaborator

xezon commented Sep 13, 2022

Ah, because they have set IsTrainable = No. The proper fix then would be to have Pilot be able to enter Bike with specific Passengers only. But that likely is Game Code.

@commy2
Copy link
Collaborator Author

commy2 commented Sep 13, 2022

Yeah. Although even that seems strange to me. Where does the Pilot go? He's obviously not the rider and a Bike has no other crew unlike any other vehicle.

@xezon
Copy link
Collaborator

xezon commented Sep 13, 2022

He hides in the Bike Cargo Box and gives instructions.

@Stubbjax
Copy link
Collaborator

The proper fix then would be to have Pilot be able to enter Bike with specific Passengers only. But that likely is Game Code.

If we're talking code changes, why not just have the pilot actually ride the bike?

@xezon
Copy link
Collaborator

xezon commented Sep 14, 2022

Does Bike with Worker gain Veterancy when driving over Scrap?

@Stubbjax
Copy link
Collaborator

Does Bike with Worker gain Veterancy when driving over Scrap?

Yes.

RANK.mp4

@Jundiyy
Copy link
Collaborator

Jundiyy commented Sep 14, 2022

Does Bike with Worker gain Veterancy when driving over Scrap?

Yes.

RANK.mp4

Yes, every GLA unit does. Even if they can't otherwise. Vet 3 Demo Bike is very powerful.

Bike will auto repair, but once the unit gets off the bike, it won't auto heal if it usually doesn't gain vet.

@xezon
Copy link
Collaborator

xezon commented Sep 14, 2022

It is odd that infantry on bike can rank up but on foot it cannot. Best case it would be consistent on Bike and on Foot, or infantry would need to lose veteran after disembarking bike.

Copy link
Collaborator

@Stubbjax Stubbjax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's reasonable to remove this weird behaviour.

  1. It makes no logical sense that the pilot is consumed by the bike.
  2. No other USA infantry can ride bikes.
  3. It's super rare so it's not like anyone is going to miss it.
  4. Promoting infantry with pilots feels like an exploit more than anything.

@Jundiyy
Copy link
Collaborator

Jundiyy commented Sep 14, 2022

Other than Worker, all infantry vetting up (in any way) wouldn't feel odd imo, on foot or bike. Hence why I mentioned it in the Sabo topic.

Workers would feel odd since they don't help in combat in any way. And because other such units don't vet up. Such as Dozers and Supply Trucks.
Hijackers, Saboteurs and Terrorists are all combat type units and would feel fine to gain vet.

I know it's another topic and too controversial, but would have been nice if EA had allowed Dozers and Trucks vet, to be rewarded for their crushes. A bit like ECMs, can't vet up other than running over Inf.

@xezon
Copy link
Collaborator

xezon commented Sep 14, 2022

So, if we merge this, then the next logical question is whether or not Bike should be Trainable, because Scrap still gives Vet.

@Stubbjax
Copy link
Collaborator

So, if we merge this, then the next logical question is whether or not Bike should be Trainable or not, because Scrap still gives Vet.

Definitely needs to be for cases like Jarmen, which often promotes very quickly when encountering Hackers.

@xezon
Copy link
Collaborator

xezon commented Sep 14, 2022

Ah right, it needs to be Trainable for the Infantry that can shoot. And Scrap cannot be changed for different types I think. At least not without INI trickery.

@commy2
Copy link
Collaborator Author

commy2 commented Sep 14, 2022

Probably can make the scrap never level up CLIFF_JUMPER kind of and instead always give money. But that would mean Jarmen and co can no longer vet up by driving over scrap either.

@xezon xezon added the OngoingDiscussion Requires further discussion label Sep 15, 2022
@commy2 commy2 removed the NProject Issue has been addressed in NProject Mod label Sep 20, 2022
@xezon xezon removed the OngoingDiscussion Requires further discussion label Oct 30, 2022
Copy link
Collaborator

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@xezon xezon merged commit 4b5e5a3 into main Oct 30, 2022
@xezon xezon deleted the fix-pilots-combat-bike branch October 30, 2022 12:56
@xezon xezon added the Nerf Makes a thing less powerful label Jan 18, 2023
@xezon xezon added the GLA Affects GLA faction label Jan 18, 2023
@xezon xezon added the Controversial Is controversial label Mar 25, 2023
@commy2 commy2 mentioned this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right Controversial Is controversial GLA Affects GLA faction Minor Severity: Minor < Major < Critical < Blocker Nerf Makes a thing less powerful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants