Change: China Overlord will always reload when idle #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Design
commy2
approved these changes
Feb 11, 2023
|
Good Change |
Stubbjax
approved these changes
Feb 12, 2023
xezon
force-pushed
the
change-overlord-reload
branch
from
331290f
to
6c4a75f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change the China Overlord will always reload when idle.
This makes the unit a bit better in scenarios where it managed to only fire with one of its barrel on its target and some time passes until the next target is attacked.
This situation is perhaps not as rare as one may assume. There is a
ClipReloadTimeof 2000 ms vs aDelayBetweenShotsof 333 (300) ms. This means there is a 14% chance that Overlord gets into state with one clip in barrels when attacking and moving Overlord around.Rationale
Eliminates situations where Overlord would only fire once on a fresh engagement. This likely is what player would expect always.
Patched
First attack fires 2 clips normally, second attack fires only 1 clip because of interruption (Stop), and third attack fires 2 clips again because of new auto reload when idle.
generals.2023-02-11.16-44-50-78.mp4