Fix: Flawed audio quality in Explosion FX sounds #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Minor
|
Sounds good to me. Documentation needs to be updated. |
xezon
force-pushed
the
fix-explosion-sounds
branch
from
485039d
to
60754ca
Compare
|
Documentation updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes clicking and fade out in all
gexpsounds, except gexpdaia.wav which is already covered by #1800. The explosion sounds now fade out gently without hard cuts.All wav files are used as is uncompressed for the time being. The original respective sampling rates of 22050 or 44100 are preserved.