Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Demo General Rebel Lacks Voice Line When Targetting Building With Booby Trap #263

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Fix: Demo General Rebel Lacks Voice Line When Targetting Building With Booby Trap #263

merged 1 commit into from
Sep 9, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 9, 2021

ZH 1.04:

  • The Demo General's Rebel does not say his line when the target is chosen for the Booby Trap ability. The normal GLA Rebel does have a voice line for this.

After patch:

  • The Demo General Rebel uses the same voice line when a target is chosen for Booby Traps.
  • The same change is applied to the Stealthed Rebel for completeness, despite the ability never being unlocked for it.

@commy2 commy2 added the Bug Something is not working right label Sep 9, 2021
@xezon xezon self-requested a review September 9, 2021 19:44
@commy2 commy2 merged commit 817e299 into main Sep 9, 2021
@commy2 commy2 deleted the fix-demo-rebel-booby-trap-voice-line branch September 9, 2021 20:13
xezon pushed a commit that referenced this pull request Aug 28, 2022
@commy2
Fix: Demo General Rebel Lacks Voice Line When Targetting Building Wit…
0b77ef2 
…h Booby Trap (#263)
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Audio Is audio related GLA Affects GLA faction labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon approved these changes

Assignees
No one assigned
Labels
Audio Is audio related Bug Something is not working right GLA Affects GLA faction Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@commy2 @xezon