Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Some Units Lack Voice Line When Ordered To Attack Airborne Targets #293

Merged
merged 1 commit into from
Sep 11, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 11, 2021

ZH 1.04

  • Some units do not play a voice line when targeting airborne units. These include: Gattling Tank, Overlord (Gattling Turret upgrade), Mini Gunner, Assault Troop Crawler, Listening Outpost, RPG-Soldier, Battle Bus, Combat Cycle.

Repro:

  • Target an airborne unit with any of these units. Note that targeting friendly airborne units with force-fire will always play the line for attacking ground targets, so chose an enemy target instead.

After patch:

  • The same effect for firing at ground units is used against airborne targets. Mostly fits. Better than staying silent.

Note:

  • In CCG VoiceAttackAir did not exist. Instead VoiceAttack was played against ground and airborne targets. VoiceAttackAir however was not added to every unit that can attack air. For some reason, they also did not make VoiceAttackAir fall back to VoiceAttack when undefined. So while units talk in CCG, they don't in ZH against air.
  • The Overlord can attack air when upgraded with Gatling. The Combat Bike when a RPG-Soldier is riding it.

@commy2 commy2 added the Bug Something is not working right label Sep 11, 2021
@xezon xezon self-requested a review September 11, 2021 10:46
@commy2 commy2 merged commit 3890d38 into main Sep 11, 2021
@commy2 commy2 deleted the fix-aa-voice-lines branch September 11, 2021 14:23
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Audio Is audio related labels Mar 18, 2023
@commy2 commy2 mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audio Is audio related Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants