Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ECM Tank Cannot Disable Heroic (Vet 3) Quad Cannons #442

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Oct 1, 2021

600 comes from the health x 2 formula used by every other unit in the game. It was 440, because Quad Cannon health used to be 220.

This fix does not include the single player only GC Quads, because those have no logic at all for ECM (will probably fix that later when those factions are to be done).

I could not find any reason to set it to 450 as suggested. They wake up in the proper order for me (vet 3 first, no vet last etc.). Following the formula makes it consistent and we avoid possible similar bugs when health bonuses vs easy/hard AI, or Hold The Line are applied on the Quad.

@commy2 commy2 added the Bug Something is not working right label Oct 1, 2021
@commy2
Copy link
Collaborator Author

commy2 commented Oct 1, 2021

quad-ecm-fixed2.mp4

@Jundiyy
Copy link
Collaborator

Jundiyy commented Oct 1, 2021

Hmmm, interesting, is the only change you've done here is the 600?
If so, perhaps there was a mistake on my end (although I only remember changing to 600),if 600 produces what you have shown then yes seems good.

@commy2
Copy link
Collaborator Author

commy2 commented Oct 1, 2021

Yeah, the video is shot using this branch.

@commy2 commy2 merged commit 3b28c58 into main Oct 1, 2021
@commy2 commy2 deleted the fix-ecm-vs-hero-quad branch October 1, 2021 15:11
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker GLA Affects GLA faction labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right GLA Affects GLA faction Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heroic Quad Cannon can never be disabled by ECM Tanks.
3 participants