Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Tank Nuke Cannon and Inferno Cannon #575

Merged
merged 3 commits into from
Oct 31, 2021
Merged

Conversation

Jundiyy
Copy link
Collaborator

@Jundiyy Jundiyy commented Oct 17, 2021

Mappers can now add Nuke Cannons and Inferno Cannons to the Tank General War Factory.

First they must use the CommandButton script to add these units to the War Factory, then they must also place down a TechWarFactory per player (off map is fine) and script them so they are given to each player.

The second route is to add the CommandButtons scripts then add scripts to ignore prerequisites.

@commy2
Copy link
Collaborator

commy2 commented Oct 18, 2021

Couldn't the map maker not just do:

CommandSet Tank_SCIENCE_CHINA_CommandSetRank1
  3 = Command_PurchaseScienceNukeLauncher
End

CommandSet Tank_ChinaWarFactoryCommandSet
  9  = Command_ConstructChinaVehicleInfernoCannon
  10 = Command_ConstructChinaVehicleNukeLauncher
End

Object ChinaVehicleInfernoCannon
  Prerequisites
    Object = ChinaPropagandaCenter Tank_ChinaPropagandaCenter
  End
End

Object ChinaVehicleNukeLauncher
  Prerequisites
    Object = ChinaPropagandaCenter Tank_ChinaPropagandaCenter
    Science = SCIENCE_NukeLauncher
  End
End

That should work in 1.04 already.

@Jundiyy
Copy link
Collaborator Author

Jundiyy commented Oct 18, 2021

This would require map.ini, which not everyone knows or a mapper may not want due to having to restart on transfer and after game.

Map makers can currently add any unit but have to remove the prerequisites through scripts, which means units can be built without tech.

The purpose of these units and some others is to allow a simple 'drag and drop', otherwise we could just ask all mappers to learn/use map.ini and no need to do changes. It's more of ease of access for them, find the units in WB and use them.

@xezon
Copy link
Collaborator

xezon commented Oct 18, 2021

With current map.ini tech it is desirable to reduce map.ini use cases, because it can cause mismatching in successive map loads.

@commy2
Copy link
Collaborator

commy2 commented Oct 18, 2021

And doesn't work immediately on transferred maps.

I think that is the underlying issue here and should be addressed, possibly by Thyme.

@xezon
Copy link
Collaborator

xezon commented Oct 18, 2021

Yes. For current developments however I believe we should not rely on Thyme and cater to original game executable as usual.

Copy link
Collaborator

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Linebreak at end of file(s) and add comments to new added features.

@Jundiyy
Copy link
Collaborator Author

Jundiyy commented Oct 18, 2021

Done.

EditorSorting = VEHICLE
TransportSlotCount = 10 ;how many "slots" we take in a transport (0 == not transportable)

; Patch104p @bugfix commy2 09/09/2021 Prevent exploit that allows Neutron Shells without upgrade.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would remove this, as that change is not made by this patch.

MaxQueueEntries = 1; So you can't build multiple upgrades in the same frame
End

; Patch104p @bugfix commy2 09/09/2021 Prevent exploit that allows Neutron Shells without upgrade.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@xezon xezon merged commit 2a6225d into main Oct 31, 2021
@xezon xezon deleted the Tank_Nuke_and_Inferno branch October 31, 2021 18:16
@xezon xezon added Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker China Affects China faction labels Mar 18, 2023
@xezon xezon changed the title Tank Nuke Cannon and Inferno Cannon Change: Tank Nuke Cannon and Inferno Cannon Mar 19, 2023
xezon added a commit that referenced this pull request Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
China Affects China faction Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants