Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Optimize China Nuke Missile blast delays: Hits max 880 ms earlier #880

Merged
merged 1 commit into from
Aug 14, 2022

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Aug 13, 2022

This change optimizes the blast delays of China Nuke Missile.

Stats

Blast delays in milliseconds.

Stat Blast 1 Blast 2 Blast 3 Blast 4 Blast 5 Blast 6
Original Nuke Missile Delay 1180
Patched Nuke Missile Delay (1) 580 660 720 850 1000 1180
Patched Nuke Missile Delay (this) 300 380 460 540 620 700

Original

nuke_missile_timing_original.mp4

Patched (this)

nuke_missile_timing_patched_2.mp4

@xezon xezon added Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker labels Aug 13, 2022
@xezon
Copy link
Collaborator Author

xezon commented Aug 13, 2022

I noticed the particle effects were not properly in sync with the blasts. I adjusted the ring particles slightly to adjust for that. Video updated. Looks good to me now.

@xezon
Copy link
Collaborator Author

xezon commented Aug 13, 2022

This change has a hidden total time buff of 880 ms or less to original Nuke Missile. Therefore I will mark this as controversial accordingly. I have not found a way to compensate for the decreased time by adding it elsewhere.

@xezon xezon added the Controversial Is controversial label Aug 13, 2022
@Jundiyy
Copy link
Collaborator

Jundiyy commented Aug 14, 2022

So it will explode 880 ms earlier than 1.04? I don't think it's too bad of a change. Seems safe. It will be even better vs armies.

@xezon
Copy link
Collaborator Author

xezon commented Aug 14, 2022

Fittingly this pull has ID #880 :-)

@xezon xezon changed the title Optimize China Nuke Missile blast delays Change: Optimize China Nuke Missile blast delays: Hits max 880 ms earlier Aug 14, 2022
@xezon xezon merged commit 86fcd8b into main Aug 14, 2022
@xezon xezon deleted the nuke-missile-blast-timing branch August 14, 2022 18:06
@ImTimK ImTimK added China Affects China faction Buff Makes a thing more powerful labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Buff Makes a thing more powerful China Affects China faction Controversial Is controversial Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants