Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Remove Damage Effects From Immortal Buildings #883

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Aug 13, 2022

@commy2 commy2 added Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker labels Aug 13, 2022
@xezon
Copy link
Collaborator

xezon commented Aug 13, 2022

I just tested this branch with shooting 5 Rockets from Helix onto Supply and it does sound the same as original.

@ImTimK
Copy link
Collaborator

ImTimK commented Aug 13, 2022

I just tested this branch with shooting 5 Rockets from Helix onto Supply and it does sound the same as original.

Because if many RPG's hit a target at the same time it creates a bigger explosion, which is what you hear, could be any target including the ground when you force fire.

@commy2
Copy link
Collaborator Author

commy2 commented Aug 13, 2022

Yeah, there are multiple sound and particle effects working here. The bigger explosion is when infantry missiles kill each other:

184476532-c545c3b6-38ad-4cbc-aeb4-9b5f1e304fb2.mp4

This effect can be removed by deleting:
Object TankHunterMissile/InstantDeathBehavior DeathModuleTag_03/FX_GenericMissileDeath

@xezon
Copy link
Collaborator

xezon commented Aug 13, 2022

Before and After videos sound the same to me.

@commy2
Copy link
Collaborator Author

commy2 commented Aug 13, 2022

Before and After videos sound the same to me.

The following recordings are made with this additional change:

-  FireSound = TankHunterWeapon
-  FireFX = FX_BuggyMissileIgnition
-  ProjectileDetonationFX = WeaponFX_RocketBuggyMissileDetonation
+  ;FireSound = TankHunterWeapon
+  ;FireFX = FX_BuggyMissileIgnition
+  ;ProjectileDetonationFX = WeaponFX_RocketBuggyMissileDetonation

which makes the Tank Hunter weapon silent.

before this pull request

before.mp4

after this pull request

after.mp4

If this is about a different sound effect, then it is unrelated to Supply Docks.

@xezon xezon merged commit d880d2e into main Aug 13, 2022
@xezon xezon deleted the fix-supply-damage-fx branch August 13, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supply stashes have damage effects but don't take any damage
3 participants