Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor_Improvement] Add I2C multi sensor single bus init and de-init functtions #33

Open
elsalahy opened this issue Jul 31, 2020 · 0 comments
Assignees
Labels
Firmware Anything related to code and SW on the HW technical debt

Comments

@elsalahy
Copy link
Contributor

Summary:

Sensor I2C init functions can call BSP init, or the BSP init can be called alone.
Need to add a handling for the senors init functions in case multiple sensors are on the same bus, in order to ensure only one BSP init is called.

Why do we need this?

To avoid un-needed re-iinit of the bus and have a coherant implementation.

What is already there? What do you see now?

Template init of the sensors.

What is missing? What do you want to see?

Flags, function checks, and harmonized implementation.

How do you propose to implement this?

  • Add Flag if the bus is initialized already,
  • Pass the I2C handler as a reference instead of using extern.
  • Handle multi-sensor bus init functions checks and returns.

Environment:

Baremetal.

Acceptance Criteria:

  • Should not affect sensors functionality in any way.
  • Basic app must compile and run smothly.

What can you do yourself and what do you need help with?

All

@elsalahy elsalahy self-assigned this Jul 31, 2020
@elsalahy elsalahy added this to the Backlog milestone Aug 3, 2020
@elsalahy elsalahy added the Firmware Anything related to code and SW on the HW label May 31, 2021
@johanstokking johanstokking removed this from the Backlog milestone Nov 29, 2021
@NicolasMrad NicolasMrad assigned azerimaker and unassigned elsalahy Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Firmware Anything related to code and SW on the HW technical debt
Projects
None yet
Development

No branches or pull requests

3 participants