Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose field mask paths and remove obsolete method #13

Merged
merged 1 commit into from Dec 9, 2018

Conversation

johanstokking
Copy link
Member

Summary:

Closes #12

Changes:

  • Expose top level and nested field mask paths
  • Remove method that copies and returns them

Copy link
Contributor

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tests and regenerate the golden files (make test)

@johanstokking johanstokking force-pushed the issue/12-expose-paths branch 2 times, most recently from 753aba8 to 92ea174 Compare December 8, 2018 12:37
@johanstokking
Copy link
Member Author

For the record, make test doesn't work for me;

Regenerating golden files...
Running tests...
--- FAIL: TestGolden (1.58s)
    main_test.go:57: Running 'docker run --user 501 --rm --mount type=bind,src=/Users/johan/dev/go/src/github.com/TheThingsIndustries/protoc-gen-fieldmask,dst=/Users/johan/dev/go/src/github.com/TheThingsIndustries/protoc-gen-fieldmask -e IN_TEST -w /Users/johan/dev/go/src/github.com/TheThingsIndustries/protoc-gen-fieldmask thethingsindustries/protoc:3.0.17 --plugin=protoc-gen-fieldmask=/Users/johan/dev/go/src/github.com/TheThingsIndustries/protoc-gen-fieldmask/.work/tmp.qCm/go-build302900878/b001/protoc-gen-fieldmask.test -Ivendor -Itestdata --fieldmask_out=/Users/johan/dev/go/src/github.com/TheThingsIndustries/protoc-gen-fieldmask/.work/tmp.qCm/fieldmask-test819603683 --gogo_out=/Users/johan/dev/go/src/github.com/TheThingsIndustries/protoc-gen-fieldmask/.work/tmp.qCm/fieldmask-test819603683 testdata/testdata.proto'...
    main_test.go:60: Output:
        /Users/johan/dev/go/src/github.com/TheThingsIndustries/protoc-gen-fieldmask/.work/tmp.qCm/go-build302900878/b001/protoc-gen-fieldmask.test: program not found or is not executable
        --fieldmask_out: protoc-gen-fieldmask: Plugin failed with status code 1.
    main_test.go:66: Error: exit status 1
FAIL
exit status 1
FAIL	github.com/TheThingsIndustries/protoc-gen-fieldmask	1.589s
make: *** [test] Error 1

I updated to 3.0.17 because the internet is too shit here to pull 3.0.15. If I'm doing something wrong, i.e. if thethingsindustries/protoc needs to be rebuilt (first), please document that.

@johanstokking johanstokking merged commit 2b83243 into master Dec 9, 2018
@johanstokking johanstokking deleted the issue/12-expose-paths branch December 9, 2018 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants