Fetch CPF configuration from GCS #9

rvolosatovs · 2019-12-10T22:17:47Z

Refs TheThingsNetwork/lorawan-stack#1716 (comment)

~~Configure frequency plan after CPF installation in provisioning script~~
Support restarting packet forwarder after configuration
Change example IP to 192.168.4.155, which is the gateway's default IP
Pull Lorad and Lorafwd configs from GCS

~~Example(with some error handling as well):~~
EDIT: removed original example, since it's not applicable anymore

rvolosatovs · 2019-12-10T22:20:29Z

The default templates do not have class B enabled, for example, but IMO this should be good enough for "average user". Customization and more advanced configuration should be done manually anyway.

README.md

johanstokking · 2019-12-11T13:24:10Z

README.md

+4) RU864-RU_8CH
+5) RU864-RU_8CH_Legacy
+6) US915-US_8CH
+Please select a frequency plan template to use for lorad configuration.[0-6]2


Where do these come from? Kerlink?

I think we have to pull this from https://github.com/TheThingsNetwork/lorawan-frequency-plans, at least the index. Then we can use GCS (https://github.com/TheThingsNetwork/lorawan-stack/blob/master/pkg/gatewayconfigurationserver/gatewayconfigurationserver.go#L70) to get the JSON file. This does require an API key with gateway info rights.

This is just what is present in the vanilla CPF DOTA - the script then simply symlinks the template to current config. The user is expected to manually adapt the config at a later stage if necessary.
We could provide functionality for more advanced configuration(e.g. enabling and configuring class B) and/or get configuration from GCS.
I am not familiar with GCS, but looking at the source code the obvious thing is that the protocol used there has nothing to do with either lorad, nor lorafwd config required here. (Referring to https://github.com/TheThingsNetwork/lorawan-stack/blob/57a326a0c4f2bc81b896ede300baff2df199baf6/pkg/pfconfig/semtechudp/semtechudp.go#L34-L40)
What is the scope of GCS? It seems that this component is used to configure gateways using data in the stack. Do users configure this in the console? Does it include things like class B parameters etc.? If it is what I think it is, then we could potentially remove all the string replacements etc. and provision.sh could just fetch both lorad and lorafwd configs from GCS given a (GCS) address and a key.
All of that is quite out of scope of this PR. Can you file an issue?

All of that is quite out of scope of this PR

What is in scope is ensuring that the right frequency plan is used. I don't care about vanilla CPF DOTA frequency plans; we have our own.

What is the format of those? Are those basically global_conf.json?

As for the lorad and lorafwd config; they may very well override what is in global_conf.json, assuming that CPF uses that format.

rvolosatovs · 2019-12-18T21:06:22Z

~~Blocked by TheThingsNetwork/lorawan-stack#1747~~

johanstokking · 2019-12-20T16:32:38Z

provision.sh

-    setLorafwdKeyQuoted "${sshCmd}" "node" "${stackAddr}"
+    pushConfig  "${gatewayAddr}" \
+                "${apiKey}" \
+                "${stackAddr}/api/v3/gcs/gateways/${gatewayID}/cpf/lorad/lorad.json" \


cpf is too generic ("common packet forwarder"); let's make sure we specifically indicate it's kerlink here, like kerlink-cpf

Also, why are these specific folders?

Yeah, that was TheThingsNetwork/lorawan-stack#1747, but I guess we can still change this since we did not make a release.
The folders are different, because these are 2 independent services - lorad and lorafwd

OK fine. Yeah please change there

johanstokking · 2019-12-20T16:39:09Z

provision.sh

-    printf "Setting LNS downlink port to ${downlinkPort}...\n" >&2
-    setLorafwdKey "${sshCmd}" "service.downlink" "${downlinkPort}"
+function printUsage {
+    printf "Usage: $0 GATEWAY-ADDRESS STACK-ADDRESS GATEWAY-ID API-KEY\n" >&2


nit; <gateway-address> <stack-address> ...

This is very much inconsistent across different tools:

But in general, from what I have seen, usually:

[] enclose optional parameters

no [] means that parameters are mandatory

<> is only used by Go

I used the suggested format, because most "old-school" Unix tooling uses that.
I don't really have a stong opinion about this, however I think <> may be confusing, since that syntax is very uncommon(i.e. the only tool I know of using that syntax is Go compiler)

Yeah OK I partly agree. In the ssh and grep cases, the command is mandatory and in [ ], though. If you execute them without a command, they just print help.

So maybe [gateway_address] [stack_address] ...?

The only mandatory part of ssh is destination, which is without []
In case of grep, the only mandatory part is the pattern, which is, again, without []
Note that FILE is not mandatory for grep:

$ echo "asd" | grep Usage: grep [OPTION]... PATTERNS [FILE]... Try 'grep --help' for more information. $ echo "asd" | grep "a" asd

See SSH as well:

rvolosatovs@cobalt ~ % ssh oxygen Last login: Thu Dec 19 12:43:52 2019 from <redacted> rvolosatovs@oxygen ~ %

johanstokking · 2019-12-23T09:51:57Z

@rvolosatovs looks like this can be updated, reviewed and merged

rvolosatovs added the enhancement label Dec 10, 2019

rvolosatovs requested a review from johanstokking December 10, 2019 22:17

rvolosatovs self-assigned this Dec 10, 2019

rvolosatovs mentioned this pull request Dec 10, 2019

Document connecting Kerlink Wirnet Station to TTS TheThingsNetwork/lorawan-stack#1716

Merged

6 tasks

rvolosatovs force-pushed the feature/provision-frequency-plan branch 4 times, most recently from 86696ce to f2ef8e8 Compare December 10, 2019 22:38

johanstokking reviewed Dec 11, 2019

View reviewed changes

rvolosatovs added this to the December 2019 milestone Dec 11, 2019

rvolosatovs added 2 commits December 12, 2019 15:15

provision.sh: Configure frequency plan after CPF installation

610d7bf

provision.sh: Support restarting packet forwarder after configuration

4e4dff5

rvolosatovs mentioned this pull request Dec 18, 2019

Add initial CPF support to GCS TheThingsNetwork/lorawan-stack#1747

Merged

6 tasks

rvolosatovs added prio/medium s/blocked s/blocking labels Dec 18, 2019

rvolosatovs force-pushed the feature/provision-frequency-plan branch from ae5ea30 to e9e3fc1 Compare December 19, 2019 10:41

rvolosatovs removed the s/blocked label Dec 19, 2019

rvolosatovs requested review from johanstokking and removed request for johanstokking December 19, 2019 10:52

rvolosatovs added the s/in progress We're working on it label Dec 19, 2019

rvolosatovs requested a review from johanstokking December 19, 2019 10:57

rvolosatovs removed the s/in progress We're working on it label Dec 19, 2019

johanstokking reviewed Dec 20, 2019

View reviewed changes

rvolosatovs mentioned this pull request Dec 20, 2019

Add "kerlink-" prefix to CPF endpoints TheThingsNetwork/lorawan-stack#1773

Merged

6 tasks

rvolosatovs requested a review from johanstokking December 23, 2019 09:55

rvolosatovs mentioned this pull request Dec 23, 2019

Document connecting a NASYS LoRaWAN Outdoor Gateway to TTS TheThingsNetwork/lorawan-stack#1765

Merged

6 tasks

johanstokking approved these changes Dec 23, 2019

View reviewed changes

rvolosatovs added 2 commits December 23, 2019 15:38

README.md: Update provisioning examples

507cc97

provision.sh: Use config from GCS

a87a11a

rvolosatovs force-pushed the feature/provision-frequency-plan branch from d06c946 to a87a11a Compare December 23, 2019 14:39

rvolosatovs changed the title ~~Configure frequency plan after CPF installation when provisioning~~ Fetch CPF configuration from GCS Dec 23, 2019

rvolosatovs merged commit 87ceb43 into master Dec 23, 2019

rvolosatovs deleted the feature/provision-frequency-plan branch December 23, 2019 14:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fetch CPF configuration from GCS #9

Fetch CPF configuration from GCS #9

rvolosatovs commented Dec 10, 2019 •

edited

Loading

rvolosatovs commented Dec 10, 2019

johanstokking Dec 11, 2019

rvolosatovs Dec 11, 2019 •

edited

Loading

johanstokking Dec 12, 2019

rvolosatovs commented Dec 18, 2019 •

edited

Loading

johanstokking Dec 20, 2019

rvolosatovs Dec 20, 2019

johanstokking Dec 20, 2019

johanstokking Dec 20, 2019

rvolosatovs Dec 20, 2019

johanstokking Dec 20, 2019 •

edited

Loading

rvolosatovs Dec 20, 2019 •

edited

Loading

johanstokking commented Dec 23, 2019

Fetch CPF configuration from GCS #9

Fetch CPF configuration from GCS #9

Conversation

rvolosatovs commented Dec 10, 2019 • edited Loading

rvolosatovs commented Dec 10, 2019

johanstokking Dec 11, 2019

Choose a reason for hiding this comment

rvolosatovs Dec 11, 2019 • edited Loading

Choose a reason for hiding this comment

johanstokking Dec 12, 2019

Choose a reason for hiding this comment

rvolosatovs commented Dec 18, 2019 • edited Loading

johanstokking Dec 20, 2019

Choose a reason for hiding this comment

rvolosatovs Dec 20, 2019

Choose a reason for hiding this comment

johanstokking Dec 20, 2019

Choose a reason for hiding this comment

johanstokking Dec 20, 2019

Choose a reason for hiding this comment

rvolosatovs Dec 20, 2019

Choose a reason for hiding this comment

johanstokking Dec 20, 2019 • edited Loading

Choose a reason for hiding this comment

rvolosatovs Dec 20, 2019 • edited Loading

Choose a reason for hiding this comment

johanstokking commented Dec 23, 2019

rvolosatovs commented Dec 10, 2019 •

edited

Loading

rvolosatovs Dec 11, 2019 •

edited

Loading

rvolosatovs commented Dec 18, 2019 •

edited

Loading

johanstokking Dec 20, 2019 •

edited

Loading

rvolosatovs Dec 20, 2019 •

edited

Loading