Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document connecting Kerlink Wirnet Station to TTS #1716

Merged
merged 2 commits into from
Dec 23, 2019
Merged

Document connecting Kerlink Wirnet Station to TTS #1716

merged 2 commits into from
Dec 23, 2019

Conversation

rvolosatovs
Copy link
Contributor

@rvolosatovs rvolosatovs commented Dec 10, 2019 •
edited
Loading

Summary

Closes #1631

Changes

  • Document connecting Kerlink Wirnet Station to TTS

Notes for Reviewers

Leaving this as draft until TheThingsNetwork/kerlink-wirnet-firmware#7 is merged

Do we need to document this in the CHANGELOG? I guess not, but @htdvisser may have a different opinion.

Based this on existing TTKG guide. Registration section is just copy-paste

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, database and configuration, according to the stability commitments in README.md.
  • Testing: The changes are covered with unit tests. The changes are tested manually as well.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@rvolosatovs rvolosatovs added documentation This involves writing user documentation blocked This can't continue until another issue or pull request is done prio/medium labels Dec 10, 2019
@rvolosatovs rvolosatovs added this to the December 2019 milestone Dec 10, 2019
@rvolosatovs rvolosatovs self-assigned this Dec 10, 2019
rvolosatovs
rvolosatovs commented Dec 10, 2019
View reviewed changes
doc/content/guides/connecting-gateways/kerlinkwirnet/_index.md Outdated
Please refer to https://github.com/TheThingsNetwork/kerlink-station-firmware#provisioning for detailed up-to-date documentation.

1. Ensure your public key is authorized for `root` user on the gateway. If that's not the case (you need to enter `root` password to login into the gateway via SSH) - execute `ssh-copy-id root@192.168.4.155`.
2. Execute `curl -sL https://raw.githubusercontent.com/TheThingsNetwork/kerlink-station-firmware/master/provision.sh | bash -s -- "192.168.4.155" "https://thethings.example.com"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered using a permlink here, but IMO using master directly is a better approach here from perspective of maintenance of this guide. In case the location/usage changes we should update this doc as well.

@coveralls
Copy link

coveralls commented Dec 10, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 73.61% when pulling 29011a4 on rvolosatovs:feature/document-kerlink-wirnet into 64000cf on TheThingsNetwork:master.

@rvolosatovs rvolosatovs mentioned this pull request Dec 10, 2019
Merged
@rvolosatovs rvolosatovs removed the blocked This can't continue until another issue or pull request is done label Dec 10, 2019
@rvolosatovs rvolosatovs mentioned this pull request Dec 10, 2019
Merged
@rvolosatovs rvolosatovs marked this pull request as ready for review December 10, 2019 22:49
@rvolosatovs rvolosatovs changed the title doc: Document connecting Kerlink Wirnet Station to TTS Document connecting Kerlink Wirnet Station to TTS Dec 10, 2019
@rvolosatovs rvolosatovs force-pushed the feature/document-kerlink-wirnet branch 2 times, most recently from ee0c0ae to 3751572 Compare December 12, 2019 13:49
@rvolosatovs rvolosatovs mentioned this pull request Dec 18, 2019
Merged
6 tasks
@rvolosatovs rvolosatovs added the blocked This can't continue until another issue or pull request is done label Dec 18, 2019
@rvolosatovs
Copy link
Contributor Author

Blocked by TheThingsNetwork/kerlink-wirnet-firmware#9

@rvolosatovs rvolosatovs force-pushed the feature/document-kerlink-wirnet branch from 3751572 to cfa1175 Compare December 18, 2019 21:09
@rvolosatovs rvolosatovs force-pushed the feature/document-kerlink-wirnet branch from 73c8143 to 318d2b7 Compare December 23, 2019 14:43
@rvolosatovs rvolosatovs removed the blocked This can't continue until another issue or pull request is done label Dec 23, 2019
@rvolosatovs
Copy link
Contributor Author

@johanstokking please review

johanstokking
johanstokking approved these changes Dec 23, 2019
View reviewed changes
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvolosatovs rvolosatovs force-pushed the feature/document-kerlink-wirnet branch from 318d2b7 to 29011a4 Compare December 23, 2019 15:23
@rvolosatovs rvolosatovs merged commit 3e2a02b into TheThingsNetwork:master Dec 23, 2019
@rvolosatovs rvolosatovs deleted the feature/document-kerlink-wirnet branch December 23, 2019 23:10
rvolosatovs pushed a commit to rvolosatovs/lorawan-stack-fork that referenced this pull request Apr 28, 2020
@johanstokking
Merge pull request TheThingsNetwork#1716 from TheThingsIndustries/fea…
757e0cd 
…ture/1705-as-awsiot

Publish telemetry to AWS IoT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neoaggelos neoaggelos neoaggelos left review comments

@johanstokking johanstokking johanstokking approved these changes

Assignees

@rvolosatovs rvolosatovs

Labels
documentation This involves writing user documentation
Projects
None yet
Milestone
December 2019
Development

Successfully merging this pull request may close these issues.

Add Kerlink Wirnet connection guide
4 participants
@rvolosatovs @coveralls @neoaggelos @johanstokking