CLI improvements proposal: subcommands #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happyRip
force-pushed
the
feature/56-cli-improvement-subcommands
branch
2 times, most recently
from
8301840
to
325f64c
Compare
happyRip
force-pushed
the
feature/56-cli-improvement-subcommands
branch
from
325f64c
to
03d4d18
Compare
happyRip
commented
Apr 25, 2023
happyRip
force-pushed
the
feature/56-cli-improvement-subcommands
branch
4 times, most recently
from
0f4f518
to
5b47c48
Compare
Execute parent's persistent pre-run in subcommands spf13/cobra#252
happyRip
force-pushed
the
feature/56-cli-improvement-subcommands
branch
from
54e2b3e
to
57cb05d
Compare
happyRip
force-pushed
the
feature/56-cli-improvement-subcommands
branch
from
57cb05d
to
d1d4bba
Compare
Closed
happyRip
force-pushed
the
feature/56-cli-improvement-subcommands
branch
from
d1d4bba
to
cf58f86
Compare
Apply the changes when `spf13/cobra` package is upgraded in `go.mod`.
Command used:
```bash
$ find . -name "*.go" -type f -exec sed -i '' 's/© 202./© 2023/g' {} \;
```
happyRip
force-pushed
the
feature/56-cli-improvement-subcommands
branch
from
cf58f86
to
738fe88
Compare
adriansmares
approved these changes
Apr 28, 2023
johanstokking
approved these changes
Apr 29, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ref #56
#65 (comment)
This PR features changes from #70
Changes
ttnv3command withdeviceandapplicationsubcommandssource.FlagSettakes an argument to return the flags for the specified sourcesource.AllFlagSetsis used. It prepends each flag name with a source names, so each flag is unique (replicating legacy behaviour)Testing
Use
ttnv3command to export devices instead of relying on the--sourceflag:Regressions
...
Notes for Reviewers
ttnv2andchirpstackcommands have been skipped for the initial iteration since they should be twin tottnv3anyway.Checklist
CHANGELOG.md.