Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of unauthorized OAuth clients by collaborators #49

Open
johanstokking opened this issue Jan 29, 2019 · 1 comment
Open

Allow use of unauthorized OAuth clients by collaborators #49

johanstokking opened this issue Jan 29, 2019 · 1 comment
Labels
c/identity server This is related to the Identity Server

Comments

@johanstokking
Copy link
Member

Summary:

We should allow collaborators of OAuth clients to use those clients before they are approved.

Why do we need this?

Would be very helpful for development.

What is already there? What do you see now?

Regular OAuth flow that rejects requests for "REQUESTED" clients.

What is missing? What do you want to see?

Before rejecting the request based on REQUESTED state, check if the current user collaborates on the OAuth client and then still allow the authorization.

How do you propose to implement this?

As described above, altough we should probably discuss the consequences first. Especially considering that you could add anyone as collaborator on the Client without them having to approve their membership.


Original issue: https://github.com/TheThingsIndustries/lorawan-stack/issues/1414 by @htdvisser

@johanstokking johanstokking added c/identity server This is related to the Identity Server l/open source labels Jan 29, 2019
@johanstokking johanstokking added this to the Backlog milestone Feb 6, 2019
@htdvisser htdvisser removed this from the Backlog milestone Jun 8, 2021
@htdvisser htdvisser removed their assignment Jul 7, 2022
@htdvisser htdvisser added the needs/triage We still need to triage this label Jul 7, 2022
@htdvisser
Copy link
Contributor

With #5414 landing in The Things Stack we can expect an increase in requests for OAuth client approvals. Since many of those clients will initially only be used for development (and not for use by the larger community) I think we should re-prioritize this issue so that we can make it easier for users to get started with developing OAuth clients without having to wait for admin approval.

cc: @NicolasMrad

@NicolasMrad NicolasMrad removed the needs/triage We still need to triage this label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/identity server This is related to the Identity Server
Projects
None yet
Development

No branches or pull requests

3 participants