New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OAuth client managment #5414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope for this PR, but I think we should at some point improve that rights selector a bit with some more structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! This is a huge PR so there are quite some comments but we're on a good track already. I didn't find any substantial issues.
164e4c3
to
63dad5f
Compare
82e73a1
to
cf3d73c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only looked at IS, I don't see any problem with unsafe-inline
for css being enabled so this looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good!
Two last things in order to align this with #5497
- Please add a
created_at
header to the OAuth client table to sort by it by default (so that the newest client will be at the top of the list) - Use the updated right tags rendering
5d1f3e6
to
91e1891
Compare
Summary
Closes #4300.
Changes
Screen.Recording.2022-04-28.at.10.32.17.mov
Screen.Recording.2022-04-28.at.10.29.44.mov
Testing
Cypress tests and manually.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.