Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OAuth client managment #5414

Merged
merged 35 commits into from May 31, 2022
Merged

Add OAuth client managment #5414

merged 35 commits into from May 31, 2022

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Apr 28, 2022

Summary

Closes #4300.

Changes

  • Add client list view;
  • Add create and edit client views;
  • Add collaborator list view;
  • Add collaborator add view;
  • Add pagination, sidebar and breadcrumbs to account app;
  • Add cypress end to end tests for client views.

Screenshot 2022-04-28 at 10 27 57

Screen.Recording.2022-04-28.at.10.32.17.mov

Screenshot 2022-04-28 at 10 29 21

Screen.Recording.2022-04-28.at.10.29.44.mov

Screenshot 2022-04-28 at 10 29 32

Screenshot 2022-04-28 at 10 34 52

Testing

Cypress tests and manually.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added c/console This is related to the Console ui/web This is related to a web interface labels Apr 28, 2022
@ryaplots ryaplots added this to the v3.19.2 milestone Apr 28, 2022
@ryaplots ryaplots self-assigned this Apr 28, 2022
@github-actions github-actions bot added c/identity server This is related to the Identity Server and removed c/console This is related to the Console labels Apr 28, 2022
@ryaplots ryaplots added the in progress We're working on it label Apr 28, 2022
Copy link
Contributor

@htdvisser htdvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope for this PR, but I think we should at some point improve that rights selector a bit with some more structure.

CHANGELOG.md Show resolved Hide resolved
Copy link
Member

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! This is a huge PR so there are quite some comments but we're on a good track already. I didn't find any substantial issues.

pkg/webui/account/store/actions/clients.js Outdated Show resolved Hide resolved
pkg/webui/components/icon/index.js Outdated Show resolved Hide resolved
pkg/webui/account/views/front/front.styl Outdated Show resolved Hide resolved
pkg/webui/account/store/selectors/collaborators.js Outdated Show resolved Hide resolved
pkg/webui/account/views/oauth-client-add/index.js Outdated Show resolved Hide resolved
pkg/webui/account/containers/collaborators-table/index.js Outdated Show resolved Hide resolved
@ryaplots ryaplots modified the milestones: v3.19.2, v3.20.0 May 18, 2022
@ryaplots ryaplots force-pushed the issue/4300-oauth-client-managment branch from 164e4c3 to 63dad5f Compare May 19, 2022 13:51
@adriansmares adriansmares changed the base branch from v3.19 to v3.20 May 20, 2022 16:51
@ryaplots ryaplots force-pushed the issue/4300-oauth-client-managment branch from 82e73a1 to cf3d73c Compare May 23, 2022 07:52
@ryaplots ryaplots requested a review from kschiffer May 23, 2022 07:53
Copy link
Contributor

@nicholaspcr nicholaspcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only looked at IS, I don't see any problem with unsafe-inline for css being enabled so this looks good to me.

Copy link
Member

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

Two last things in order to align this with #5497

@ryaplots ryaplots force-pushed the issue/4300-oauth-client-managment branch from 5d1f3e6 to 91e1891 Compare May 31, 2022 09:06
@ryaplots ryaplots merged commit f3ee1d2 into v3.20 May 31, 2022
@ryaplots ryaplots deleted the issue/4300-oauth-client-managment branch May 31, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/identity server This is related to the Identity Server in progress We're working on it ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAuth Client management in the Console
4 participants