Do not use t.Fatal in goroutines #183

M-Gregoire · 2019-02-22T07:27:38Z

Summary:
Closes #182

Changes:

JS: Return an error when {G,S}etByIDFunc is called where it shouldn't
~~- NS: Use Error instead of Fail as described in Use Error instead of Fatal in tests goroutines #182~~

M-Gregoire added c/join server This is related to the Join Server c/network server This is related to the Network Server labels Feb 22, 2019

M-Gregoire added this to the February 2019 milestone Feb 22, 2019

M-Gregoire self-assigned this Feb 22, 2019

M-Gregoire requested a review from rvolosatovs February 22, 2019 07:27

htdvisser modified the milestones: February 2019, March 2019 Feb 26, 2019

rvolosatovs approved these changes Mar 4, 2019

View reviewed changes

js: Fail when SetByEUIFunc shouldn't be called

de566cf

rvolosatovs force-pushed the issue/182-use-error-in-goroutines branch from ed4d99e to de566cf Compare March 4, 2019 19:00

rvolosatovs assigned rvolosatovs and unassigned M-Gregoire Mar 4, 2019

rvolosatovs changed the title ~~Issue/182 use error in goroutines~~ Do not use t.Fatal in goroutines Mar 4, 2019

rvolosatovs merged commit e35ce50 into master Mar 4, 2019

rvolosatovs deleted the issue/182-use-error-in-goroutines branch March 4, 2019 19:16

Provide feedback