New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release EUIs of deleted gateways #1843
Conversation
set the gateway_eui field to null after soft deletion
dc51ab8
to
a6c0b1a
Compare
47bb541
to
798fe98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
…/multi-tenant-dcs Fix duplicate tenant prefix in DCS
Hi I still see an issue when I use the CLI to delete a gateway, and then I cannot re-add the gateway with the same id.
any way to workaround this!? |
The EUI was released when you deleted the gateway, but the ID is still reserved. This is for security reasons, as historical data (in external integrations) is linked to the ID, and if someone else would register a gateway with the same ID after you delete it, they would have access to your historical data, which probably isn't what you want. With #3467 it's possible for admin users to release the IDs, but of course that could cause some security issues like the one I described above. |
Summary
Closes #1120
Changes
afterDelete
hook for gateways to reset their eui.Checklist
README.md
.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.