Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NS/AS KEK labels, AS-ID, NetID to device create form #2038

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

bafonins
Copy link
Contributor

Summary

References #1134

Changes

  • Add application_kek_label, network_kek_label, application_server_id and net_id fields to the device create form
  • Update validation schema accordingly

Notes for Reviewers

Since #579 is taking longer than expected and still requires some work, I think we should make the create and edit forms consistent. After #1616 the user can edit those fields, while it is still not possible to edit them while creating an end device.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, database and configuration, according to the stability commitments in README.md.
  • Testing: The changes are covered with unit tests. The changes are tested manually as well.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

application/network kek labels, net id, application server id
@bafonins bafonins added c/console This is related to the Console ui/web This is related to a web interface labels Feb 24, 2020
@bafonins bafonins added this to the February 2020 milestone Feb 24, 2020
@bafonins bafonins self-assigned this Feb 24, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 73.316% when pulling 2cfac35 on feature/device-form-fields into 4001d2f on master.

Copy link
Member

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bafonins bafonins merged commit c1ef81e into master Feb 25, 2020
@bafonins bafonins deleted the feature/device-form-fields branch February 25, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants