-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LoRaWAN 1.1 support #2307
Fix LoRaWAN 1.1 support #2307
Conversation
Tested this with FF1705 running mbed-os with patch from ARMmbed/mbed-os#12762 applied on top of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, but the lack of unit tests is a bit "smelly" IMO.
The
|
529f484
to
cb57888
Compare
Summary
References #2171
Changes
b0
currently is actuallyb1
according to the spec, that also caused the confusion in making me think that the implementation is incorrect, let's fix this to avoid this happening in the future.DeviceModeInd
being marked as "initiated by NS"pkg/crypto
CODEOWNERS
Checklist
README.md
.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.