Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send event stream start events #2989

Merged

Conversation

rvolosatovs
Copy link
Contributor

@rvolosatovs rvolosatovs commented Jul 28, 2020

Summary

References #2950

Changes

  • Reintroduce events.stream.start

Testing

Ran console

Regressions

Console-related

Notes for Reviewers

Please DO NOT depend on events.stream.start - console must completely ignore this event, the only purpose of it is to ensure that headers are sent.
As part of #2950 I will later investigate how we could fix this without relying on such workarounds. ( hence, also, the issue is not closed, but merely referenced)
Assigning @johanstokking since I'm almost done for today and off tomorrow

@kschiffer these entries should not be present:
2020-07-28-15:53:05-screenshot

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@rvolosatovs rvolosatovs added bug Something isn't working c/console This is related to the Console prio/high blocking release This is blocking a release labels Jul 28, 2020
@rvolosatovs rvolosatovs added this to the July 2020 milestone Jul 28, 2020
Copy link
Contributor

@htdvisser htdvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please remove the line "Event stream start and stop events are not published anymore." from CHANGELOG instead of adding a line that they are sent.

Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the change from the changelog as it's effectively reverted when it's not released yet

@johanstokking johanstokking merged commit 917d485 into TheThingsNetwork:v3.9 Jul 28, 2020
@rvolosatovs rvolosatovs deleted the fix/console-event-streams branch July 30, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking release This is blocking a release bug Something isn't working c/console This is related to the Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants