Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References #2950
Changes
events.stream.start
Testing
Ran console
Regressions
Console-related
Notes for Reviewers
Please DO NOT depend on
events.stream.start
- console must completely ignore this event, the only purpose of it is to ensure that headers are sent.As part of #2950 I will later investigate how we could fix this without relying on such workarounds. ( hence, also, the issue is not closed, but merely referenced)
Assigning @johanstokking since I'm almost done for today and off tomorrow
@kschiffer these entries should not be present:
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.