New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of FCnt resets and 32-bit FCnt rollovers #3738
Conversation
b2ebd98
to
b5f9dc6
Compare
@rvolosatovs: This only affects |
yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why GitHub decided to request code-owner review on a draft PR. Only quickly glanced over it.
ef1b3cd
to
c09bcad
Compare
Co-authored-by: Erik van Bennekum <erik@thethingsindustries.com>
52b6220
to
c47eeef
Compare
c47eeef
to
7d3de79
Compare
cd740c4
to
e197c30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me. We're definitely going to need to verify that this all works in a new rc, so let's get that going as soon as this is merged.
Summary
Closes #3728
Refs #3743
Changes
Testing
Unit tests, integration testing
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.