Remove populators from tests #4452

johanstokking · 2021-07-26T15:57:27Z

References #342

Remove usage of populators from pkg/joinserver tests, and some housekeeping along the way

CI

No functional changes

Scope: The referenced issue is addressed, there are no unrelated changes.
Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
Documentation: Relevant documentation is added or updated.
Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

js: Remove obsolete test; empty JoinEUI is allowed

69f5de0

johanstokking added the technical debt Not necessarily broken, but could be done better/cleaner label Jul 26, 2021

johanstokking added this to the v3.14.1 milestone Jul 26, 2021

johanstokking self-assigned this Jul 26, 2021

johanstokking requested a review from adriansmares as a code owner July 26, 2021 15:57

github-actions bot added the c/join server This is related to the Join Server label Jul 26, 2021

johanstokking mentioned this pull request Jul 26, 2021

Remove generated message populators from pkg/ttnpb #342

Closed

adriansmares approved these changes Jul 26, 2021

View reviewed changes

js: Rewrite tests without populators

ef8dccb

johanstokking force-pushed the issue/342-js branch from 0597213 to 6d64dd0 Compare July 26, 2021 17:44

util: Rewrite encoding/lorawan tests without populators

104c6b3

johanstokking force-pushed the issue/342-js branch from 6d64dd0 to 104c6b3 Compare July 27, 2021 07:52

johanstokking merged commit 06cd2e1 into v3.14 Jul 27, 2021

johanstokking deleted the issue/342-js branch July 27, 2021 08:03

Provide feedback