Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove populators for Application, Client, Gateway, Organization and User #4488

Merged
merged 4 commits into from
Aug 10, 2021

Conversation

htdvisser
Copy link
Contributor

@htdvisser htdvisser commented Aug 4, 2021

Summary

This removes the populator options for entities used in the Identity Server.

While working on the test for public fields, I also thought I'd clarify which fields are public in the documentation, so I updated the field comments.

Refs #342

Changes

  • Stop using populators in IS
  • Stop using populators in public field test
  • Improve documentation of public fields
  • Remove Application, Client, Gateway, Organization and User populators

Testing

Existing tests

Regressions

None expected; populators were never used in production code.

Notes for Reviewers

Scheduled this for v3.14.2 but depending on time, it may still land in v3.14.1.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@htdvisser htdvisser added the technical debt Not necessarily broken, but could be done better/cleaner label Aug 4, 2021
@htdvisser htdvisser added this to the v3.14.2 milestone Aug 4, 2021
@htdvisser htdvisser self-assigned this Aug 4, 2021
@github-actions github-actions bot added c/identity server This is related to the Identity Server compat/api This could affect API compatibility compat/db This could affect Database compatibility labels Aug 4, 2021
@htdvisser htdvisser merged commit b803331 into v3.14 Aug 10, 2021
@htdvisser htdvisser deleted the issue/342-is-populators branch August 10, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/identity server This is related to the Identity Server compat/api This could affect API compatibility compat/db This could affect Database compatibility technical debt Not necessarily broken, but could be done better/cleaner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants