Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grpc address of the IS for TTS CE in the CLI #4507

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Fix grpc address of the IS for TTS CE in the CLI #4507

merged 2 commits into from
Aug 10, 2021

Conversation

KrishnaIyer
Copy link
Member

Summary

Fix grpc address of the IS for TTS CE in the CLI

Changes

  • Fix grpc address of the IS for TTS CE in the CLI

Testing

Locally built and tested

Regressions

NA

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@KrishnaIyer KrishnaIyer added this to the v3.14.2 milestone Aug 10, 2021
@KrishnaIyer KrishnaIyer self-assigned this Aug 10, 2021
@github-actions github-actions bot added the ui/cli This is related to ttn-lw-cli label Aug 10, 2021
htdvisser
htdvisser approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@htdvisser htdvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@KrishnaIyer KrishnaIyer merged commit f78aedc into v3.14 Aug 10, 2021
@KrishnaIyer KrishnaIyer deleted the fix/cli-use branch August 10, 2021 06:57
@KrishnaIyer KrishnaIyer mentioned this pull request Aug 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htdvisser htdvisser htdvisser approved these changes

@neoaggelos neoaggelos neoaggelos approved these changes

@adriansmares adriansmares Awaiting requested review from adriansmares

Assignees

@KrishnaIyer KrishnaIyer

Labels
ui/cli This is related to ttn-lw-cli
Projects
None yet
Milestone
v3.14.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KrishnaIyer @htdvisser @neoaggelos