Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove populators from NS and AS tests #4626

Merged
merged 4 commits into from
Sep 15, 2021
Merged

Remove populators from NS and AS tests #4626

merged 4 commits into from
Sep 15, 2021

Conversation

KrishnaIyer
Copy link
Member

Summary

Remove populators from NS and AS tests. Refs #342 (comment)

Changes

  • Remove populators from NS and use handwritten generator.
  • Remove unused populator in AS.

Testing

UT

Regressions

NA

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@KrishnaIyer KrishnaIyer self-assigned this Sep 15, 2021
@KrishnaIyer KrishnaIyer added the technical debt Not necessarily broken, but could be done better/cleaner label Sep 15, 2021
@KrishnaIyer KrishnaIyer added this to the 2021 Q3 milestone Sep 15, 2021
@github-actions github-actions bot added c/application server This is related to the Application Server c/network server This is related to the Network Server labels Sep 15, 2021
@github-actions github-actions bot added the compat/db This could affect Database compatibility label Sep 15, 2021
@KrishnaIyer KrishnaIyer merged commit 0b7db0f into v3.15 Sep 15, 2021
@KrishnaIyer KrishnaIyer deleted the feature/342-ns-populators branch September 15, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansmares adriansmares adriansmares approved these changes

@johanstokking johanstokking Awaiting requested review from johanstokking

Assignees

@KrishnaIyer KrishnaIyer

Labels
c/application server This is related to the Application Server c/network server This is related to the Network Server compat/db This could affect Database compatibility technical debt Not necessarily broken, but could be done better/cleaner
Projects
None yet
Milestone
2021 Q3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KrishnaIyer @adriansmares