Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leftovers of populators #4718

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Remove leftovers of populators #4718

merged 1 commit into from
Oct 11, 2021

Conversation

htdvisser
Copy link
Contributor

Summary

This removes some leftovers of the populators we used to have.

Refs #342 and #2798

Testing

Existing tests.

Regressions

This should all be dead code anyway, so removing it shouldn't make a difference.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@htdvisser htdvisser added the technical debt Not necessarily broken, but could be done better/cleaner label Oct 7, 2021
@htdvisser htdvisser added this to the v3.15.2 milestone Oct 7, 2021
@htdvisser htdvisser self-assigned this Oct 7, 2021
@github-actions github-actions bot added the security This is important for security label Oct 7, 2021
@johanstokking
Copy link
Member

CI is happy so I'm happy here

@htdvisser htdvisser merged commit e78055f into v3.15 Oct 11, 2021
@htdvisser htdvisser deleted the issue/populators branch October 11, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanstokking johanstokking johanstokking approved these changes

@adriansmares adriansmares adriansmares approved these changes

Assignees

@htdvisser htdvisser

Labels
security This is important for security technical debt Not necessarily broken, but could be done better/cleaner
Projects
None yet
Milestone
v3.15.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@htdvisser @johanstokking @adriansmares