Add basic gateways CRUD operations to js sdk #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bafonins
added
c/console
kschiffer
requested changes
May 3, 2019
|
|
||
| // Delete | ||
|
|
||
| async deleteById (id) { |
There was a problem hiding this comment.
I think it's better if we also unwrap the results here using Marshaler.payloadSingleResponse(). Same thing with Applications.delete().
add basic CRUD operations
unmarshal response for the delete operation
bafonins
force-pushed
the
feature/26-gateways-service
branch
from
959952e
to
ec8b4e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds basic crud operations to the gateways service in js sdk.
References: #26
Changes