Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event stream concurrency and state machine #6776

Merged
merged 12 commits into from
Dec 18, 2023

Conversation

kschiffer
Copy link
Member

Summary

This is hopefully the last fix to the event stream logic. It adds a proper state machine store logic and addresses various state edge cases.

Changes

  • Store subscriptions properly per connection (including ws instaces)
  • Add state machine logic to read on modify from the currently stored connections and subscriptions

Testing

Manual testing on staging on Chrome and Firefox

Notes for Reviewers

Please test various scenarios:

  • Testing in different browsers
  • Testing multiple subscriptions (when checking device events)
  • Testing interruption of the stream (eg. CTRL-C the stack)
  • Refreshing many times

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer added bug Something isn't working c/console This is related to the Console c/sdk/js This is related to the JavaScript SDK labels Dec 14, 2023
@kschiffer kschiffer added this to the v3.29.0 milestone Dec 14, 2023
@kschiffer kschiffer self-assigned this Dec 14, 2023
@kschiffer kschiffer requested a review from a team as a code owner December 14, 2023 11:19
@github-actions github-actions bot added the ui/web This is related to a web interface label Dec 14, 2023
@adriansmares adriansmares merged commit edb7c34 into v3.29 Dec 18, 2023
7 of 8 checks passed
@adriansmares adriansmares deleted the fix/event-stream-reconnect-4 branch December 18, 2023 10:48
@adriansmares adriansmares mentioned this pull request Dec 18, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/console This is related to the Console c/sdk/js This is related to the JavaScript SDK ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants