Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable OpenTelemetry metrics #6976

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

adriansmares
Copy link
Contributor

Summary

References open-telemetry/opentelemetry-go-contrib#5190
References #5692

This PR disables OpenTelemetry metrics (which we don't use), and remove some long standing technical debt.

Changes

  • Remove OpenCensus as a dependency.
    • OpenCensus is now defunct, and it is replaced by OpenTelemetry completely.
    • We didn't really use the metrics exposed by OpenCensus, so this is safe to do.
  • Skip metric creation in OpenTelemetry integrations.
    • pkg/metrics is Prometheus based and it is currently not exposing these metrics, so we don't need them.
    • At the same time, current metrics are leaky (see the referenced issue), so disabling them is required even.

Testing

Local testing with the /metrics endpoint in order to ensure that I am not accidentally taking out useful metrics.

No manual testing required.

Regressions

The OpenCensus hooks were not really used, and I cannot find any OpenCensus metrics in our Prometheus clusters, so we should not have any specific regressions.

Notes for Reviewers

This will be backported to v3.29.1 for the leak fix.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added the bug Something isn't working label Mar 6, 2024
@adriansmares adriansmares added this to the v3.30.0 milestone Mar 6, 2024
@adriansmares adriansmares self-assigned this Mar 6, 2024
@github-actions github-actions bot added dependencies Pull requests that update a dependency file tooling Development tooling labels Mar 6, 2024
@adriansmares adriansmares marked this pull request as ready for review March 6, 2024 18:03
@adriansmares adriansmares requested review from a team as code owners March 6, 2024 18:03
@adriansmares
Copy link
Contributor Author

This has been deployed, and confirmed as working.

@adriansmares adriansmares merged commit 4269bce into v3.30 Mar 7, 2024
16 checks passed
@adriansmares adriansmares deleted the feature/removel-otel-metrics branch March 7, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file tooling Development tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants