Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References open-telemetry/opentelemetry-go-contrib#5190
References #5692
This PR disables OpenTelemetry metrics (which we don't use), and remove some long standing technical debt.
Changes
pkg/metrics
is Prometheus based and it is currently not exposing these metrics, so we don't need them.Testing
Local testing with the
/metrics
endpoint in order to ensure that I am not accidentally taking out useful metrics.No manual testing required.
Regressions
The OpenCensus hooks were not really used, and I cannot find any OpenCensus metrics in our Prometheus clusters, so we should not have any specific regressions.
Notes for Reviewers
This will be backported to
v3.29.1
for the leak fix.Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.