Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NbTrans controls while using Dynamic ADR mode #7012

Merged
merged 16 commits into from Apr 10, 2024

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Mar 27, 2024

Summary

Closes #6966

Changes

  • Add store for band definitions
  • Add NbTrans override fields (default override and specific override)
  • Add encoding and decoding of the checkbox
  • Fix browser console errors

Testing

Screen.Recording.2024-03-27.at.12.47.45.mp4
  1. Login into the console
  2. Go to any device/create and application and device
  3. Go to device settings, to Network Server section and open the collapsed "Avanced MAC settings" section.
  4. Select ADR Dynamic mode.
  5. Uncheck Use default settings for number of retransmissions
  6. Click Add data rate specific override and add the data rate and NbTrans
  7. Then save changes. The specific override should be saved.
  8. Remove the specific override and refresh.
  9. There should be no overrides.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@github-actions github-actions bot added the ui/web This is related to a web interface label Mar 27, 2024
@ryaplots ryaplots self-assigned this Mar 27, 2024
@ryaplots ryaplots added this to the v3.30.0 milestone Mar 27, 2024
@ryaplots ryaplots marked this pull request as ready for review March 27, 2024 12:15
@ryaplots ryaplots requested a review from a team as a code owner March 27, 2024 12:15
Copy link
Contributor

@PavelJankoski PavelJankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, LGTM!

@kschiffer
Copy link
Member

Please wait with merging, I have a pending review.

@kschiffer kschiffer self-requested a review March 28, 2024 15:54
Copy link
Member

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, but the devil is in the details here. Please see my suggestion about using valueSetter to align the form values with the backend shape and avoiding custom data marshalling.
feature/adr-nbtrans-controls...feature/adr-nbtrans-controls-2

@KrishnaIyer KrishnaIyer modified the milestones: v3.30.0, v3.30.1 Apr 4, 2024
@ryaplots ryaplots requested a review from kschiffer April 8, 2024 14:51
Copy link
Member

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! See my two small remarks.

pkg/webui/console/components/mac-settings-section/index.js Outdated Show resolved Hide resolved
pkg/webui/console/views/device-general-settings/index.js Outdated Show resolved Hide resolved
@ryaplots ryaplots merged commit 47ecec5 into v3.30 Apr 10, 2024
12 of 13 checks passed
@ryaplots ryaplots deleted the feature/adr-nbtrans-controls branch April 10, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support fine-grained NbTrans controls while using Dynamic ADR mode
4 participants